gpsbabel.git
7 years agoadd support for multiple urls for route headers. (#276)
tsteven4 [Thu, 20 Dec 2018 16:38:22 +0000 (09:38 -0700)]
add support for multiple urls for route headers. (#276)

* add support for multiple urls for route headers.

add support in gpx for gpx/rte/link, gpx/rte/url, gpx/rte/urlname.
add support in gpx for gpx/trk/link, gpx/trk/url, gpx/trk/urlname.

Note that the gpx writer can violate the schema when fprint_xml_chain
is used to echo unrecognized elements from input to output.
This is because the gpx 1.0/1.1 schema requires an xsd:sequence of
elements, i.e. the order of the elements is specified, and any
elements output by fprint_xml_chain won't necessarily be in
the correct order with other elements that are specifically
handled in the gpx writer.

By processing additional gpx elements as listed above on read we
prevent them from causing schema violations on write.  However,
other unrecognized elements can still cause schema violations.

* make common link code common in gpx reader.

7 years agoadd cppcheck target to GPSBabel.pro. (#280)
tsteven4 [Fri, 14 Dec 2018 14:24:23 +0000 (07:24 -0700)]
add cppcheck target to GPSBabel.pro. (#280)

* add cppcheck target to GPSBabel.pro.

fix a few cppcheck errors.

* fix a few cppcheck items.

strptime fix is from upstream.

7 years agogenerate html coverage reports. (#281)
tsteven4 [Sun, 2 Dec 2018 23:52:22 +0000 (16:52 -0700)]
generate html coverage reports. (#281)

* generate html coverage reports.

* tweak coverage recipe.

7 years agoremove obsolete msvc workarounds. (#278)
tsteven4 [Sat, 1 Dec 2018 15:03:37 +0000 (08:03 -0700)]
remove obsolete msvc workarounds. (#278)

msvc 2012 and earlier are not supported.
They didn't support c++14 anyway which we currently require.

7 years agouse QThread::usleep instead of our own function. (#277)
tsteven4 [Wed, 28 Nov 2018 14:00:10 +0000 (07:00 -0700)]
use QThread::usleep instead of our own function. (#277)

Our test suite doesn't test sleep, but the nmea pause option
can be used on write to verify functionality interactively.

7 years agoobsolete DEBUG_MEM (#279)
tsteven4 [Wed, 28 Nov 2018 01:48:17 +0000 (18:48 -0700)]
obsolete DEBUG_MEM (#279)

7 years agosimplify conversion from utm. (#275)
tsteven4 [Tue, 27 Nov 2018 23:37:49 +0000 (16:37 -0700)]
simplify conversion from utm. (#275)

* simplify conversion from utm.

add test cases for Norway and Svalbard exceptions.

* Correct bug in computing latitude band X.

enhance test to cover exceptional width of band X.

7 years agoupdate shapelib to 1.4.1 (#274)
tsteven4 [Sat, 24 Nov 2018 18:59:45 +0000 (11:59 -0700)]
update shapelib to 1.4.1 (#274)

7 years agoenhance sort filter for rtes & trks. (#273)
tsteven4 [Mon, 19 Nov 2018 18:54:46 +0000 (11:54 -0700)]
enhance sort filter for rtes & trks. (#273)

7 years agouse bool, true, false. (#272)
tsteven4 [Sat, 17 Nov 2018 22:06:31 +0000 (15:06 -0700)]
use bool, true, false. (#272)

7 years agoadd msvc2017 builds to appveyor. (#270)
tsteven4 [Wed, 14 Nov 2018 16:41:06 +0000 (09:41 -0700)]
add msvc2017 builds to appveyor. (#270)

7 years agoupdate docker build script to use latest bionic. (#269)
tsteven4 [Wed, 14 Nov 2018 15:42:28 +0000 (08:42 -0700)]
update docker build script to use latest bionic. (#269)

7 years agoMerge pull request #266 from tsteven4/clazy1
tsteven4 [Wed, 14 Nov 2018 15:09:23 +0000 (08:09 -0700)]
Merge pull request #266 from tsteven4/clazy1

Incorporate improvements found by Qt oriented code checker clazy

7 years agoMerge pull request #267 from gpsbabel/gpsbabel-patch-2
GPSBabel [Wed, 14 Nov 2018 02:42:14 +0000 (20:42 -0600)]
Merge pull request #267 from gpsbabel/gpsbabel-patch-2

Remove leftover code from 'adding class' change

7 years agoRemove leftover code from 'adding class' change
GPSBabel [Tue, 13 Nov 2018 21:07:09 +0000 (15:07 -0600)]
Remove leftover code from 'adding class' change

As tsteven4 points out, No reasing to move is_internal to local and back

7 years agofix clazy detected 'use isEmpty() instead'
tsteven4 [Tue, 13 Nov 2018 15:53:34 +0000 (08:53 -0700)]
fix clazy detected 'use isEmpty() instead'

this is from -Wclazy-isempty-vs-count

7 years agofix clazy detected 'Use *Ref() instead'
tsteven4 [Tue, 13 Nov 2018 15:30:46 +0000 (08:30 -0700)]
fix clazy detected 'Use *Ref() instead'

These are from -Wclazy-qstring-ref, and were automatically fixed.

7 years agofix clazy detected 'unused *'
tsteven4 [Tue, 13 Nov 2018 15:18:09 +0000 (08:18 -0700)]
fix clazy detected 'unused *'

these are from -Wclazy-unused-non-trivial-variable

7 years agofix clazy detected 'allocating an unneeded temporary container'
tsteven4 [Tue, 13 Nov 2018 14:59:10 +0000 (07:59 -0700)]
fix clazy detected 'allocating an unneeded temporary container'

these are from -Wclazy-container-anti-pattern

Also, consistently use range based for loops in csv_util.cc

7 years agofix clazy detected 'c++11 range-loop might detach Qt container'
tsteven4 [Mon, 12 Nov 2018 16:13:28 +0000 (09:13 -0700)]
fix clazy detected 'c++11 range-loop might detach Qt container'

these are from -Wclazy-range-loop

7 years agofix clazy detected 'Use multi-arg instead'
tsteven4 [Mon, 12 Nov 2018 15:12:21 +0000 (08:12 -0700)]
fix clazy detected 'Use multi-arg instead'

these are from -Wclazy-qstring-arg

7 years agoupdate travis for xenial (#265)
tsteven4 [Sun, 4 Nov 2018 17:36:58 +0000 (10:36 -0700)]
update travis for xenial (#265)

* update travis to use xenial.

add new travis target to build on xenial.
switch travis coverage generation to xenial.
update codacy upload tool for compatibility with newer java on xenial.

* fix gcov issues with "cannot open notes file"

7 years agosupport kml 2.3 track element. (#264)
tsteven4 [Fri, 2 Nov 2018 13:55:31 +0000 (07:55 -0600)]
support kml 2.3 track element. (#264)

* support kml 2.3 track element.

relax ordering requirement for gx:Track when and
coord children.

* fix kml includes and indentation.

7 years agoMerge pull request #261 from gpsbabel/gpsbabel-patch-2
GPSBabel [Fri, 19 Oct 2018 21:30:04 +0000 (16:30 -0500)]
Merge pull request #261 from gpsbabel/gpsbabel-patch-2

Update dependencies, notably for <optional>

7 years agoReplace queues with Qlist in session handling. (#263)
tsteven4 [Fri, 19 Oct 2018 12:13:51 +0000 (06:13 -0600)]
Replace queues with Qlist in session handling. (#263)

session tracks a possible series of input formats and input filenames.

7 years agoMerge pull request #262 from tsteven4/tcache
tsteven4 [Tue, 16 Oct 2018 16:21:00 +0000 (10:21 -0600)]
Merge pull request #262 from tsteven4/tcache

extend travis mac cache timeout.

7 years agoextend travis mac cache timeout.
tsteven4 [Tue, 16 Oct 2018 15:21:22 +0000 (09:21 -0600)]
extend travis mac cache timeout.

7 years agoMerge pull request #260 from tsteven4/cpp14_msvc
tsteven4 [Tue, 16 Oct 2018 13:00:54 +0000 (07:00 -0600)]
Merge pull request #260 from tsteven4/cpp14_msvc

move to c++14 standard.

7 years agoMerge pull request #259 from tsteven4/queue_bye_bye
GPSBabel [Tue, 16 Oct 2018 05:54:13 +0000 (00:54 -0500)]
Merge pull request #259 from tsteven4/queue_bye_bye

eliminate queues in csv style handling.

7 years agoUpdate dependencies, notably for <optional>
GPSBabel [Tue, 16 Oct 2018 05:22:42 +0000 (00:22 -0500)]
Update dependencies, notably for <optional>

7 years agoMerge pull request #256 from tsteven4/rpath
tsteven4 [Tue, 16 Oct 2018 02:14:44 +0000 (20:14 -0600)]
Merge pull request #256 from tsteven4/rpath

have configure conditionally set rpath.

7 years agomove to c++14 standard.
tsteven4 [Tue, 16 Oct 2018 01:26:53 +0000 (19:26 -0600)]
move to c++14 standard.

7 years agoeliminate queues in csv style handling.
tsteven4 [Mon, 15 Oct 2018 17:00:54 +0000 (11:00 -0600)]
eliminate queues in csv style handling.

also:
fix bug with style option encoding.
pass some parameters by const reference.
eliminate some unused time fiddling.

7 years agoMerge pull request #258 from tsteven4/sortbug
tsteven4 [Thu, 11 Oct 2018 18:40:19 +0000 (12:40 -0600)]
Merge pull request #258 from tsteven4/sortbug

correct sort filter time option to use msecs.

7 years agocorrect sort filter time option to use msecs.
tsteven4 [Thu, 11 Oct 2018 17:28:41 +0000 (11:28 -0600)]
correct sort filter time option to use msecs.

7 years agouse consistent whitespace in configure comments.
tsteven4 [Tue, 9 Oct 2018 19:42:37 +0000 (13:42 -0600)]
use consistent whitespace in configure comments.

7 years agohave configure conditionally set rpath.
tsteven4 [Tue, 9 Oct 2018 18:47:42 +0000 (12:47 -0600)]
have configure conditionally set rpath.

this may be necessary when using a Qt installation
that was not provided by the system.

7 years agoMerge pull request #255 from gpsbabel/parallel
GPSBabel [Tue, 9 Oct 2018 05:45:25 +0000 (00:45 -0500)]
Merge pull request #255 from gpsbabel/parallel

Parallelize CLI and GUI make.

7 years agoParallelize CLI and GUI make. testo and vtesto are harder.
Robert Lipe [Tue, 9 Oct 2018 04:57:28 +0000 (04:57 +0000)]
Parallelize CLI and GUI make. testo and vtesto are harder.

7 years agoMerge pull request #254 from gpsbabel/tweaks
GPSBabel [Tue, 9 Oct 2018 04:20:55 +0000 (23:20 -0500)]
Merge pull request #254 from gpsbabel/tweaks

Move more xcsv processing into QStrings. Fewer conversions

7 years agoAllow string to be modified during parse. Ugh.
Robert Lipe [Tue, 9 Oct 2018 03:27:05 +0000 (03:27 +0000)]
Allow string to be modified during parse. Ugh.

7 years agoLet xcsv parser keep QStrings up for one more level.
Robert Lipe [Mon, 8 Oct 2018 23:20:45 +0000 (18:20 -0500)]
Let xcsv parser keep QStrings up for one more level.

7 years agoPush QStrings -> char * conversions down one more level.
Robert Lipe [Mon, 8 Oct 2018 23:17:34 +0000 (18:17 -0500)]
Push QStrings -> char * conversions down one more level.

7 years agoMerge pull request #253 from gpsbabel/tweaks
GPSBabel [Mon, 8 Oct 2018 23:14:58 +0000 (18:14 -0500)]
Merge pull request #253 from gpsbabel/tweaks

Find gsed when doing a tools/docfix on a Mac populated by Homebrew: G…

7 years agoFind gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr...
Robert Lipe [Mon, 8 Oct 2018 19:21:04 +0000 (14:21 -0500)]
Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/

7 years agoMerge pull request #252 from gpsbabel/tweaks
GPSBabel [Mon, 8 Oct 2018 19:20:31 +0000 (14:20 -0500)]
Merge pull request #252 from gpsbabel/tweaks

Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/

7 years agoMerge pull request #249 from codacy-badger/codacy-badge
GPSBabel [Sat, 6 Oct 2018 04:24:14 +0000 (23:24 -0500)]
Merge pull request #249 from codacy-badger/codacy-badge

Add a Codacy badge to README.md

7 years agoAdd codacy badges to Github README.md
GPSBabel [Fri, 14 Sep 2018 21:05:48 +0000 (16:05 -0500)]
Add codacy badges to Github README.md

7 years agoAdd Codacy badge
The Codacy Badger [Fri, 14 Sep 2018 20:55:52 +0000 (20:55 +0000)]
Add Codacy badge

7 years agoMerge pull request #246 from tsteven4/trackdata
tsteven4 [Sat, 1 Sep 2018 12:52:27 +0000 (06:52 -0600)]
Merge pull request #246 from tsteven4/trackdata

introduce optional class

7 years agointroduce optional class
tsteven4 [Thu, 30 Aug 2018 16:36:07 +0000 (10:36 -0600)]
introduce optional class

for things that may or may not have a value.
demonstrate usage with computed_trkdata.

7 years agoMerge pull request #245 from tsteven4/exif2
tsteven4 [Sat, 25 Aug 2018 22:37:27 +0000 (16:37 -0600)]
Merge pull request #245 from tsteven4/exif2

a few exif cleanups.

7 years agoa few exif cleanups.
tsteven4 [Sat, 25 Aug 2018 21:17:03 +0000 (15:17 -0600)]
a few exif cleanups.

7 years agoMerge pull request #230 from tsteven4/bng
tsteven4 [Thu, 23 Aug 2018 00:22:25 +0000 (18:22 -0600)]
Merge pull request #230 from tsteven4/bng

allow unicsv bng input to use all numeric grid references.

7 years agotweak unicsv bng documentation thanks Hornbydd.
tsteven4 [Wed, 22 Aug 2018 23:51:34 +0000 (17:51 -0600)]
tweak unicsv bng documentation thanks Hornbydd.

7 years agoMerge pull request #238 from tsteven4/exif
tsteven4 [Wed, 22 Aug 2018 21:27:44 +0000 (15:27 -0600)]
Merge pull request #238 from tsteven4/exif

update exif format replacing queues, legacy time_t, tm, localtime, gmtime with Qt classes.
enhance exif rational number approximation using continued fractions.
support uncompressed thumbnails on write.
make debug support dynamic based on debug level instead of a conditional compile.
enhance exif test for write.

7 years agoadd exif support for uncompressed thumbnails.
tsteven4 [Wed, 22 Aug 2018 15:37:13 +0000 (09:37 -0600)]
add exif support for uncompressed thumbnails.

7 years agofix exif dynamic debug omissions.
tsteven4 [Wed, 22 Aug 2018 00:03:43 +0000 (18:03 -0600)]
fix exif dynamic debug omissions.

7 years agofix exif warnings.
tsteven4 [Tue, 21 Aug 2018 21:05:29 +0000 (15:05 -0600)]
fix exif warnings.

7 years agoreplace legacy time handling in exif.
tsteven4 [Tue, 21 Aug 2018 18:09:00 +0000 (12:09 -0600)]
replace legacy time handling in exif.

also add support of exif OffsetTime* tags.

7 years agominor fixes for exif.
tsteven4 [Sun, 19 Aug 2018 22:43:51 +0000 (16:43 -0600)]
minor fixes for exif.

7 years agouse QVariant to store exif tag data.
tsteven4 [Sun, 19 Aug 2018 22:03:50 +0000 (16:03 -0600)]
use QVariant to store exif tag data.

enhance exif debug capability.

7 years agouse continued fractions to create TIFF RATIONAL types.
tsteven4 [Sat, 18 Aug 2018 18:50:07 +0000 (12:50 -0600)]
use continued fractions to create TIFF RATIONAL types.

some references were regenerated as the new algorithm
can generate different values for the RATIONAL numerator
and denominator, in this case 0.0 -> 0/INT32_MAX.

7 years agoimprovements to exif format.
tsteven4 [Thu, 16 Aug 2018 23:53:13 +0000 (17:53 -0600)]
improvements to exif format.

fix bugs with rational types including greatest common divisor.
turn off assertions for release builds in GPSBabel.pro.
clean up exif.

7 years agotweak endian routines for consistency. (#242)
tsteven4 [Wed, 8 Aug 2018 14:31:19 +0000 (08:31 -0600)]
tweak endian routines for consistency. (#242)

align util routeines with prototypes using readability-inconsistent-declaration-parameter-name.

7 years agoeliminate queues in inifile. (#239)
tsteven4 [Thu, 2 Aug 2018 01:21:18 +0000 (19:21 -0600)]
eliminate queues in inifile. (#239)

* eliminate queues in inifile replacing them with QHashs

* replace use of gbfile in inifile with QTextStream

7 years agoFinal presubmit cleanups
Robert Lipe [Tue, 31 Jul 2018 09:08:28 +0000 (04:08 -0500)]
Final presubmit cleanups

Ship it when it’s green. (and it’s tomorrow, errr, today.)

7 years agoFix leak in last cleanup.
Robert Lipe [Tue, 31 Jul 2018 05:34:44 +0000 (00:34 -0500)]
Fix leak in last cleanup.

Mixing C pointers and sane pointers is killing me…

7 years agoRewrite xcsv_parse_style_buff() in a readable way
Robert Lipe [Tue, 31 Jul 2018 05:18:11 +0000 (00:18 -0500)]
Rewrite xcsv_parse_style_buff() in a readable way

…might be more clever with a QStringRef, but this is hardly a
performance path.

7 years agoDegrubbify for submit
Robert Lipe [Tue, 31 Jul 2018 04:42:17 +0000 (23:42 -0500)]
Degrubbify for submit

Remove “global” char*’s in body of csv format parser. Make argument
type String to allow fixing callers later. Reformat. Fix bugs of char*
and QString[] being out of sync by eliminating one source of truth.

7 years agoFix crash in -^ generating doc list
Robert Lipe [Tue, 31 Jul 2018 00:29:14 +0000 (19:29 -0500)]
Fix crash in -^ generating doc list

vecs_t is no longer a struct of POD. It’s now a class and has to be
allocated by new. I hope to not have to rathole in vets for this change
because it’s full of scary memory management like this.

7 years agoResync with work copy
Robert Lipe [Mon, 30 Jul 2018 08:29:46 +0000 (03:29 -0500)]
Resync with work copy

7 years agoMerge branch 'master' into cleanups
Robert Lipe [Mon, 30 Jul 2018 06:09:39 +0000 (01:09 -0500)]
Merge branch 'master' into cleanups

7 years agoxcdv to data structures continues
Robert Lipe [Mon, 30 Jul 2018 06:00:17 +0000 (01:00 -0500)]
xcdv to data structures continues

Passes testo. Exposes lots of weird stuff (all marked with FIXMEs) that
are still held up with C pointer magic, but we eliminate a few hundred
cases, so I’m just looking for a test run before digging deeper.

7 years agoMore data structure work in xcsv
Robert Lipe [Mon, 30 Jul 2018 01:48:54 +0000 (20:48 -0500)]
More data structure work in xcsv

Push QStringification up two levels. Keep table and callers of
substations in Qt-land to keep QHash happy and reduce copy/leak in most
cases.

7 years agofix codacy/cppcheck whining.
tsteven4 [Mon, 23 Jul 2018 22:02:03 +0000 (16:02 -0600)]
fix codacy/cppcheck whining.

7 years agoincorporate review suggestions and fix bugs.
tsteven4 [Mon, 23 Jul 2018 21:06:48 +0000 (15:06 -0600)]
incorporate review suggestions and fix bugs.

correct user comment encoding based on image endianness.
fix possible tag corruption when data fits in 4 bytes depending
on image endianness and processor endianness.

7 years agoAllow field options in ifield, ofield
Robert Lipe [Sun, 22 Jul 2018 06:41:05 +0000 (01:41 -0500)]
Allow field options in ifield, ofield

Options can make fields.size() of 4, so loosen error test for those.
Misc warning fixes.

7 years agoPick up dropped file from last commit
Robert Lipe [Sun, 22 Jul 2018 06:22:39 +0000 (01:22 -0500)]
Pick up dropped file from last commit

Ooops. Add xcd.cc back to this CL.

7 years agoMove csv & style handlers to real C++ containers
Robert Lipe [Sun, 22 Jul 2018 05:19:50 +0000 (00:19 -0500)]
Move csv & style handlers to real C++ containers

Goal: eliminate lots of manual string bashing.

Currently waffles between the two approaches, but I wanted to get this
into GitHub for valgrind results.

7 years agofix new exif memory leaks.
tsteven4 [Fri, 20 Jul 2018 11:05:13 +0000 (05:05 -0600)]
fix new exif memory leaks.

7 years agofix exif test to run in any time zone.
tsteven4 [Fri, 20 Jul 2018 01:51:51 +0000 (19:51 -0600)]
fix exif test to run in any time zone.

7 years agoreplace exif format usage of queues.
tsteven4 [Thu, 19 Jul 2018 21:43:14 +0000 (15:43 -0600)]
replace exif format usage of queues.

7 years agoupdate gpx handling of global/metadata. (#236)
tsteven4 [Mon, 16 Jul 2018 13:49:19 +0000 (07:49 -0600)]
update gpx handling of global/metadata. (#236)

* update gpx handling of global/metadata.

use qt containers instead of queue.
add support for gpx/metadata/link.

* incorporate suggestions from review.

* update notes on justification for concatenating metadata.

7 years agoMerge pull request #234 from tsteven4/reinterp
tsteven4 [Sun, 15 Jul 2018 00:13:53 +0000 (18:13 -0600)]
Merge pull request #234 from tsteven4/reinterp

use reinterpret_cast with queue processing

7 years agouse reinterpret_cast with queues.
tsteven4 [Sat, 14 Jul 2018 23:01:41 +0000 (17:01 -0600)]
use reinterpret_cast with queues.

7 years agouse reinterpret_cast with queue processing
tsteven4 [Sat, 14 Jul 2018 15:06:27 +0000 (09:06 -0600)]
use reinterpret_cast with queue processing

instead of a static cast to a void pointer followed
by a static cast to a Waypoint*.

7 years agoMerge pull request #231 from tsteven4/jeeps
tsteven4 [Fri, 13 Jul 2018 13:11:48 +0000 (07:11 -0600)]
Merge pull request #231 from tsteven4/jeeps

obsolete jeeps/gpsproj.h.

7 years agoclean up some Variable * is reassigned a value before the old one has been used....
tsteven4 [Fri, 13 Jul 2018 00:18:08 +0000 (18:18 -0600)]
clean up some Variable * is reassigned a value before the old one has been used. (#232)

one of these was actually a very old bug.

7 years agoobsolete jeeps/gpsproj.h.
tsteven4 [Thu, 12 Jul 2018 21:46:38 +0000 (15:46 -0600)]
obsolete jeeps/gpsproj.h.

Note that jeeps/gpsproj.cc is not used.
Historically some routines have been copied from gpsproj.cc to
gpsmath.cc.  When/If this is done the corresponding headers from
gpsproj.h should be copied to gpsmath.h.

7 years agoallow unicsv bng input to use all numeric grid references.
tsteven4 [Thu, 12 Jul 2018 15:19:57 +0000 (09:19 -0600)]
allow unicsv bng input to use all numeric grid references.

7 years agoconst qualify some function parameters. (#229)
tsteven4 [Thu, 12 Jul 2018 14:51:26 +0000 (08:51 -0600)]
const qualify some function parameters. (#229)

This is the clang-tidy check readability-non-const-parameter.

7 years agorefactor "Declarator and assignment can be joined." (#227)
tsteven4 [Wed, 11 Jul 2018 22:56:20 +0000 (16:56 -0600)]
refactor "Declarator and assignment can be joined." (#227)

* refactor "Delarator and assignment can be joined."

Instances involving switch statements or goto statemens were skipped.
jeeps was skipped as well.

* fix pointer formatting case.

* more whitespace corrections.

7 years agoMerge pull request #228 from tsteven4/gdb
tsteven4 [Tue, 10 Jul 2018 16:28:20 +0000 (10:28 -0600)]
Merge pull request #228 from tsteven4/gdb

fix irrelevant booboo in 23cb08f17.

7 years agofix irrelevant booboo in 23cb08f17.
tsteven4 [Tue, 10 Jul 2018 15:53:07 +0000 (09:53 -0600)]
fix irrelevant booboo in 23cb08f17.

This only mattered if NEW_STRINGS wasn't defined,
and it always is, except if running cppcheck.

7 years agoMerge pull request #226 from tsteven4/resetb4read
tsteven4 [Mon, 9 Jul 2018 18:19:35 +0000 (12:19 -0600)]
Merge pull request #226 from tsteven4/resetb4read

refactor cases of "Declarator is reassigned in all paths before being read"
when the declarator and the subsequent assignment can be joined.

7 years agorecover some lost comments.
tsteven4 [Mon, 9 Jul 2018 17:35:53 +0000 (11:35 -0600)]
recover some lost comments.

7 years agorefactor cases of "Declarator is reassigned in all
tsteven4 [Mon, 9 Jul 2018 17:19:51 +0000 (11:19 -0600)]
refactor cases of "Declarator is reassigned in all
paths before being read"
when the declarator and the subsequent assignment can be joined.

7 years agoMerge pull request #224 from tsteven4/unusedinit
tsteven4 [Mon, 9 Jul 2018 13:16:42 +0000 (07:16 -0600)]
Merge pull request #224 from tsteven4/unusedinit

limit scope of loop vars, prefer prefix operators.

7 years agouse prefix increment on enums in brauniger_iq, garmin_txt, igc.
tsteven4 [Mon, 9 Jul 2018 01:21:28 +0000 (19:21 -0600)]
use prefix increment on enums in brauniger_iq, garmin_txt, igc.